garydgregory commented on a change in pull request #145: Added family property
URL: 
https://github.com/apache/httpcomponents-core/pull/145#discussion_r324460280
 
 

 ##########
 File path: 
httpcore5/src/main/java/org/apache/hc/core5/http/message/StatusLine.java
 ##########
 @@ -100,4 +118,84 @@ public String toString() {
         return buf.toString();
     }
 
+    /**
+     * Standard classes of HTTP status codes, plus {@code OTHER} for 
non-standard codes.
+     *
+     * @see <a href="https://tools.ietf.org/html/rfc2616#section-10";>HTTP/1.1, 
Section 10</a>
+     */
+    public enum StatusClass {
+
+        /**
+         * Informational {@code 1xx} HTTP status codes.
+         *
+         * @see <a 
href="https://tools.ietf.org/html/rfc2616#section-10.1";>HTTP/1.1, Section 
10.1</a>
+         */
+        INFORMATIONAL,
+
+        /**
+         * Successful {@code 2xx} HTTP status codes.
+         *
+         * @see <a 
href="https://tools.ietf.org/html/rfc2616#section-10.2";>HTTP/1.1, Section 
10.2</a>
+         */
+        SUCCESSFUL,
+
+        /**
+         * Redirection {@code 3xx} HTTP status codes.
+         *
+         * @see <a 
href="https://tools.ietf.org/html/rfc2616#section-10.3";>HTTP/1.1, Section 
10.3</a>
+         */
+        REDIRECTION,
+
+        /**
+         * Client Error {@code 4xx} HTTP status codes.
+         *
+         * @see <a 
href="https://tools.ietf.org/html/rfc2616#section-10.4";>HTTP/1.1, Section 
10.4</a>
+         */
+        CLIENT_ERROR,
+
+        /**
+         * {@code 5xx} HTTP status codes.
+         *
+         * @see <a 
href="https://tools.ietf.org/html/rfc2616#section-10.5";>HTTP/1.1, Section 
10.5</a>
+         */
+        SERVER_ERROR,
+
+        /**
+         * Any other HTTP status codes (e.g. non-standard status codes).
+         */
+        OTHER;
+
+        /**
+         * Get the response status class for the given status code.
+         *
+         * @param statusCode response status code to get the class for.
+         * @return class of the response status code.
+         */
+        public static StatusClass of(final int statusCode) {
 
 Review comment:
   I think "from" reads better than "of". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to