ok2c commented on issue #151: TLS session and HTTP/1.1 data buffering improvements URL: https://github.com/apache/httpcomponents-core/pull/151#issuecomment-534574361 This is a big and potentially destabilizing change-set but it improves several critical aspects in the TLS session and HTTP/1.1 protocol handlers that always tended to be prone to rather nasty data buffering issues. Most commonly those issues manifest themselves as connections stuck with the last unprocessed chunk of data stuck in internal buffers but with no more input on the socket channel. I do hope that class of defects will be completely eliminated with this change-set. Change-log: 1. I/O event handlers can now proactively push data they have read ahead down to the event pipeline instead of expecting downstream handlers to pull that data from the session channel at some point. 1. No more application input data buffered in the SSL/TLS session layer 1. Less critical session locking in the SSL/TLS session layer 1. Simpler HTTP/1.1 input processing logic with just one processing loop 1. HTTP/1.1 event handler no longer needs to be "greedy" with input. @rschmitt @rhernandez35 Could you please see if this affects your code in any way? All tests pass for me without any modifications but please feel free to test this change-set internally. @rhashimoto There is now a much better for HTTPCORE-599. Could you please see if the new code works for you as expected?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
