rschmitt commented on a change in pull request #166: Enforce h2 TLS rules after
negotiating TLS, not before
URL:
https://github.com/apache/httpcomponents-client/pull/166#discussion_r329232970
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/AbstractClientTlsStrategy.java
##########
@@ -130,7 +131,15 @@ public void initialize(final NamedEndpoint endpoint,
final SSLEngine sslEngine)
@Override
public TlsDetails verify(final NamedEndpoint endpoint, final
SSLEngine sslEngine) throws SSLException {
verifySession(host.getHostName(), sslEngine.getSession());
- return createTlsDetails(sslEngine);
+ final TlsDetails tlsDetails = createTlsDetails(sslEngine);
+ final String negotiatedCipherSuite =
sslEngine.getSession().getCipherSuite();
+ if (tlsDetails != null &&
"h2".equals(tlsDetails.getApplicationProtocol())) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
