[
https://issues.apache.org/jira/browse/HTTPCORE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953594#comment-16953594
]
Yannick Dylla commented on HTTPCORE-607:
----------------------------------------
Hi,
thanks for the quick response. I tested the fix and it works fine.
The only thing I noticed is that the SocketTimeoutException is still logged to
the exception logger (this was also added with HTTPCORE-482). In my opinion
this should not be the case, at least for idle keep alive connections, because
it is not really an error but normal operation. In my use case this would cause
many false positives and I have to ignore this kind of SocketTimeoutException
based on their string message. Which is a bit ugly, but needed because
SocketTimeoutExceptions cause by any other reason should be handled normally.
But maybe there are other use cases where it is helpful/wanted to be notified
about closed keep alive connections?
> Unwanted/wrong http header after keep alive timeout
> ---------------------------------------------------
>
> Key: HTTPCORE-607
> URL: https://issues.apache.org/jira/browse/HTTPCORE-607
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.4.11, 4.4.12
> Reporter: Yannick Dylla
> Assignee: Oleg Kalnichevski
> Priority: Major
> Fix For: 4.4.13
>
> Attachments: KeepAliveExampleClient.java,
> KeepAliveExampleServer.java, httpcore-nio-4.4.11-unwanted-504-header.pcapng,
> httpcore-nio-4.4.6-working.pcapng
>
>
> Hi,
> I think I found a regression or rather a bug. I noticed that
> {{httpcore-nio:4.4.11}} is always sending a 504 gateway timeout header after
> a connection times out. This also happens with keep alive connections where
> the application code already send a valid response, which then leads to the
> client receiving an unexpected http header. Many clients seam to ignore it
> but this is not valid http.
> This behavior was added with HTTPCORE-482 and thus {{httpcore-nio:4.4.6}} is
> the last version that in my opinion works correctly by just closing the tcp
> connection. Maybe a solution is that the connection remembers that it already
> send a response instead of a complete reset and now is in keep alive mode?
> You can see/reproduce this with the following server & client example while
> capturing their traffic with wireshark.
> 1. Start wireshark with the filter: {{tcp.srcport == 12345 || tcp.dstport ==
> 12345}}
> 2. Start the server ([^KeepAliveExampleServer.java]) which then listens on
> port 12345 with a 10s socket timeout and always responds with "Hello World".
> 3. Start the client ([^KeepAliveExampleClient.java]) which will make 3
> requests against the server. The 1st & 2nd request should use the same tcp
> connection. The 3rd should happen after the socket timeout of the server and
> thus open a new tcp connection.
> I have also prepared some captures for you, the unwanted http header is in
> packet 12 of [^httpcore-nio-4.4.11-unwanted-504-header.pcapng]. The capture
> [^httpcore-nio-4.4.6-working.pcapng] shows the expected behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
