garydgregory commented on issue #156: [HTTPCORE-611] Minor glitches with TimeValue. URL: https://github.com/apache/httpcomponents-core/pull/156#issuecomment-549377687 Hi @ok2c Why does it need a re-spin? GitHub shows "This branch has no conflicts with the base branch" @michael-o is not convinced and you gave a thumbs up. I see this PR as addressing an edge-case but it does refactor the code nicely IMO. Since this is a general utility class, providing some polish with a Locale API seems like a nice to have but not a must-have. Is the concern that the number separator is localized but the enum name is not?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
