[
https://issues.apache.org/jira/browse/HTTPCORE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971799#comment-16971799
]
Peter Frank commented on HTTPCORE-613:
--------------------------------------
Here is the new PR with the change coming from master, I couldn't close out my
other PR so I just created a new branch of master and used that:
[https://github.com/apache/httpcomponents-core/pull/160]
> Add staleConnectionCheckEnabled=true semantic behavior in
> validateAfterInactivity config
> ----------------------------------------------------------------------------------------
>
> Key: HTTPCORE-613
> URL: https://issues.apache.org/jira/browse/HTTPCORE-613
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.4.12
> Reporter: Peter Frank
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Between HttpClient 4.4.x and 4.5.x setStaleConnectionCheckEnabled was
> deprecated in favor of setValidateAfterInactivity. That's all fine, however,
> the implementation of setValidateAfterInactivity has no ability to check if a
> connection is stale all the time. The closest one can get is 1 ms, and
> that's unfortunately not short enough in a test environment scenario when a
> test Http Server is being restarted between Tests to clear out state.
> This is a common issue on the internet for people that use something like
> Wiremock, the irony is troubleshooting the situation makes it go away (cause
> logging slows the tests).
> I would suggest making 0 a special value to "turn on" validation all the time.
> With HttpClient 5 removing the old staleConnectionCheckEnabled completely
> with a piece of what that feature actually did also being removed I fear it
> will leave me, and perhaps others, in a bit of a lurch. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
