michael-o commented on a change in pull request #161: EntityUtils clean ups and
internal refactoring
URL:
https://github.com/apache/httpcomponents-core/pull/161#discussion_r347098545
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/EntityUtils.java
##########
@@ -121,17 +127,27 @@ public static void consume(final HttpEntity entity)
throws IOException {
}
}
+ private static CharArrayBuffer toCharArrayBuffer(final InputStream
inStream, final long contentLength,
+ final Charset charset) throws IOException {
+ final Charset actualCharset = charset == null ? DEFAULT_CHARSET :
charset;
+ final CharArrayBuffer buf = new CharArrayBuffer(
+ contentLength > 0 ? (int) contentLength :
DEFAULT_CHAR_BUFFER_SIZE);
Review comment:
Same here for the length...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
