pfrank13 commented on a change in pull request #160: HTTPCORE-613_2: Now 
allowing 0 for validaterAfterInactivity
URL: 
https://github.com/apache/httpcomponents-core/pull/160#discussion_r347120239
 
 

 ##########
 File path: 
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/nio/pool/H2ConnPool.java
 ##########
 @@ -137,7 +137,7 @@ protected void validateSession(
             final IOSession ioSession,
             final Callback<Boolean> callback) {
         final TimeValue timeValue = validateAfterInactivity;
-        if (TimeValue.isPositive(timeValue)) {
+        if (TimeValue.ZERO_MILLISECONDS.equals(timeValue) || 
TimeValue.isPositive(timeValue)) {
 
 Review comment:
   Sorry missed your message hopefully what I changed it works

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to