[
https://issues.apache.org/jira/browse/HTTPCLIENT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980524#comment-16980524
]
ASF subversion and git services commented on HTTPCLIENT-2028:
-------------------------------------------------------------
Commit 72af7cf5a55041b61f52d9304d5f709be2cf471e in httpcomponents-client's
branch refs/heads/master from Peter Frank
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=72af7cf ]
HTTPCLIENT-2028: Now allowing 0 for validateAfterInactivity
The purpose of this change is to allow stale checking all the time, in previous
versions of HttpClient this was accomplished by
staleConnectionCheckEnabled=true which is now removed, this adds that idea back
> Restore staleConnectionCheckEnabled=true semantic behavior in
> validateAfterInactivity config
> --------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2028
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2028
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5, 4.5.1, 4.5.2, 4.5.3, 4.5.4, 4.5.5, 4.5.6, 4.5.7,
> 4.5.8, 4.5.9, 4.5.10
> Reporter: Peter Frank
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Between HttpClient 4.4.x and 4.5.x setStaleConnectionCheckEnabled was
> deprecated in favor of setValidateAfterInactivity. That's all fine, however,
> the implementation of setValidateAfterInactivity has no ability to check if a
> connection is stale all the time. The closest one can get is 1 ms, and
> that's unfortunately not short enough in a test environment scenario when a
> test Http Server is being restarted between Tests to clear out state.
> This is a common issue on the internet for people that use something like
> Wiremock, the irony is troubleshooting the situation makes it go away (cause
> logging slows the tests).
> I would suggest making 0 a special value to "turn on" validation all the time.
> With HttpClient 5 removing the old staleConnectionCheckEnabled completely
> with a piece of what that feature actually did also being removed I fear it
> will leave me, and perhaps others, in a bit of a lurch. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
