[
https://issues.apache.org/jira/browse/HTTPCLIENT-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982353#comment-16982353
]
ASF subversion and git services commented on HTTPCLIENT-2030:
-------------------------------------------------------------
Commit 9552d5dd1d21407be98427444c27d678006dc9c9 in httpcomponents-client's
branch refs/heads/master from Niels Basjes
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=9552d5d ]
HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames
> PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain
> names.
> ----------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2030
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2030
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Reporter: Niels Basjes
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Assume
> PublicSuffixMatcher matcher = PublicSuffixMatcherLoader.getDefault();
> Then this
> matcher.getDomainRoot("www.example.unknown")
> returns
> "unknown"
> which is correct because no expectation was given about the domain name.
> However when I do set a required expectation with something like
> matcher.getDomainRoot("www.example.unknown", DomainType.ICANN)
> then the current implementation still returns
> "unknown"
> instead of the expected
> null
> indicating that there was no match.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
