ok2c commented on a change in pull request #165: Fix
`SETTINGS_HEADER_TABLE_SIZE` implementation
URL:
https://github.com/apache/httpcomponents-core/pull/165#discussion_r357842115
##########
File path:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
##########
@@ -121,8 +121,7 @@ public String toString() {
.setPushEnabled(INIT_ENABLE_PUSH)
.setMaxConcurrentStreams(Integer.MAX_VALUE) // no limit
.setMaxFrameSize(INIT_MAX_FRAME_SIZE)
- .setInitialWindowSize(INIT_WINDOW_SIZE)
- .setHeaderTableSize(Integer.MAX_VALUE); // unlimited
+ .setInitialWindowSize(INIT_WINDOW_SIZE);
Review comment:
> Fair enough, but this option is not actually implemented.
I am presently working on it unless you want me to focus on something more
important blocking the GA release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
