rschmitt commented on a change in pull request #165: Fix
`SETTINGS_HEADER_TABLE_SIZE` implementation
URL:
https://github.com/apache/httpcomponents-core/pull/165#discussion_r357860031
##########
File path:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
##########
@@ -121,8 +121,7 @@ public String toString() {
.setPushEnabled(INIT_ENABLE_PUSH)
.setMaxConcurrentStreams(Integer.MAX_VALUE) // no limit
.setMaxFrameSize(INIT_MAX_FRAME_SIZE)
- .setInitialWindowSize(INIT_WINDOW_SIZE)
- .setHeaderTableSize(Integer.MAX_VALUE); // unlimited
+ .setInitialWindowSize(INIT_WINDOW_SIZE);
Review comment:
I don't have a root cause or even a detailed problem description yet, but
I've observed that `SubscribeToShardIntegrationTest` fails when
`H2Config#setInitialWindowSize` is called with a non-default window size. In
fact, even setting the initial window size to 65,534 (i.e. one less than the
default) seems to consistently result in `FLOW_CONTROL_ERROR`s from the server.
This is the most severe bug I'm currently able to reproduce. (The `IOSession`
shutdowns are even more concerning, but I don't have a repro case at the
moment.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
