michael-o commented on issue #190: [HTTPCLIENT-2042] AuthScope uses uppercase for scheme name whereas th… URL: https://github.com/apache/httpcomponents-client/pull/190#issuecomment-569411027 > > > > Another approach would also be to leave as-is because AuthScheme#getName() is retained as-is and lowercased where ever appropriate. That would be even better for consistency. > > @michael-o I am not sure I understand the need to make any changes of what so ever, so leaving things as is would be my preference. Let me rephrase the confusing inconsistency I see: `AuthScheme#getName()` returns the scheme name as-is while `AuthScope#getScheme()` returns it in uppercase for no apparent reason. It that better to understand?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
