Folks,
this has been bugging me for some time lately and I'd like to know your
opinion about it. I am also convinced that this may confuse some of your
client users:
We have:
* interface AuthScheme with String #getName()
* enum AuthSchemes which should be singular and maybe StandardAuthScheme
with the auth schemes we support out of the box. Or similar to
StandardCharsets have "final class StandardAuthSchemes" which has only
"final static Sting SYMBOLIC_NAME = "AuthSchemeName".
For me the enum implies that this is an exhaustive list of schemes we
support, nothing else more possible.
* class AuthScope with String #getAuthScheme(). Logically, I would
expect here to be returned an instance of AuthScheme and not a string.
Otherise it should be "String #getSchemeName()"
* HTTPCLIENT-2041, HTTPCLIENT-2042
* class AuthChallenge with "String #getScheme()" same with AuthScope
* class AuthExchange with "AuthSheme #getAuthScheme"
* RequestConfig "Collection<String
#(target|proxy)PreferredAuthSchemes()" same with AuthScope
and maybe other spots I have missed.
CookieSpec and friends have the same issue.
Am I just paranoid or do you consider them to be inconsistent as well?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
