scottgifford commented on issue #191: Cache http URL: https://github.com/apache/httpcomponents-client/pull/191#issuecomment-569516739 > I am somewhat confused why the memcached is competely gone. The approach seems to be the same. > Logically, it looks fine to me, but I am not acquant with the cache code at all. It is only a change in naming, following a corresponding change in naming and approach between the 4.5.x branch and master. In the 4.5.x branch, the serializers are specific to the cache; the interface implemented for 4.5.x was called [MemcachedCacheEntry](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedCacheEntry.java) and the reference implementation is [MemcachedCacheEntryImpl](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedCacheEntryImpl.java). So my original change followed that convention. In the master branch, the serializers are not cache-specific. and the naming convention has been changed to reflect that. Here the interface I am implementing is called [HttpCacheEntrySerializer](https://github.com/apache/httpcomponents-client/blob/master/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpCacheEntrySerializer.java) and the reference implementation is [ByteArrayCacheEntrySerializer](https://github.com/apache/httpcomponents-client/blob/master/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ByteArrayCacheEntrySerializer.java). My updated code follows this convention.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
