On Tue, 2019-12-31 at 15:10 -0500, Gary Gregory wrote: > This is -1 from me, as this a classic anti-pattern: You are using the > enum's ordinal value for sorting :-( > > I am guessing Micheal will also recognize this from Effective Java's > guidelines "Never derive a value associated with an enum from its > ordinal; > store it in an instance field instead". > > Guess what happens if you change the order of the enum values in the > source? Everything breaks. > > Please revert. >
I will revert this commit as long as I can also revert your previous commit if that is OK with you. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
