garydgregory commented on issue #193: Authschemename rework URL: https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570062747 @michael-o I could go either way here. We have an almost 1-1 mapping before this patch between the enum and the interface impls (except for one impl marked experimental.) But of course, the enum and impls know nothing of each other. It is also not possible for the enum to implement an interface since each impl carries state. At least a simple port to this 'enum implements an interface' is not there, but something better might still be possible. I see the current code base as disconnected since the enum, interface and impls don't really tie in to each other. So this patch seems ok. I'll leave it up to you :-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
