michael-o edited a comment on issue #182: Add infrastructure for Docker-enabled integration tests URL: https://github.com/apache/httpcomponents-core/pull/182#issuecomment-570777543 Rejecting this PR for two reasons: * It is not portable, it fails everywhere where Docker ist not available/installed: > [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (start-httpbin) on project httpcore5-testing: Execution start-httpbin of goal io.fabric8:docker-maven-plugin:0.31.0:start failed: No <dockerHost> given, no DOCKER_HOST environment variable, no read/writable '/var/run/docker.sock' or '//./pipe/docker_engine' and no external provider like Docker machine configured -> [Help 1] E.g. on: ``` [mosipov@mika-ion ~/Projekte/httpcomponents-core]$ mvn -v Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00) Maven home: /usr/local/share/java/maven Java version: 1.8.0_222, vendor: Oracle Corporation, runtime: /usr/local/openjdk8/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "freebsd", version: "11.3-release-p3", arch: "i386", family: "unix" ``` * I highly doubt that the images pulled ran be routed through a repo manager, thus it requires outbound internet access making the tests not selfcontained. If you think this adds value, this must go into a profile.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
