+1
My review is based on the git tag.

Building 'mvn -V clean verify package' OK with and a Maven toolchain
containing (among others) Oracle Java 1.7.0_80:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_231\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache RAT check OK
Apache CLIRR check not done since irrelevant.

Also tested with the toolchain disabled using 'mvn -V test
-P-use-toolchains' for the following Java versions:

java version "1.8.0_231"
Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)

java version "11.0.5" 2019-10-15 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.5+10-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.5+10-LTS, mixed mode)

openjdk version "12" 2019-03-19
OpenJDK Runtime Environment (build 12+32)
OpenJDK 64-Bit Server VM (build 12+32, mixed mode, sharing)

openjdk version "13.0.1" 2019-10-15
OpenJDK Runtime Environment (build 13.0.1+9)
OpenJDK 64-Bit Server VM (build 13.0.1+9, mixed mode, sharing)

openjdk version "14-ea" 2020-03-17
OpenJDK Runtime Environment (build 14-ea+30-1385)
OpenJDK 64-Bit Server VM (build 14-ea+30-1385, mixed mode, sharing)

openjdk version "15-ea" 2020-09-15
OpenJDK Runtime Environment (build 15-ea+4-63)
OpenJDK 64-Bit Server VM (build 15-ea+4-63, mixed mode, sharing)

Gary


On Sat, Jan 4, 2020 at 6:46 AM Oleg Kalnichevski <[email protected]> wrote:

> Please vote on releasing these packages as HttpCore 5.0-beta11.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The vote passes if at least
> three binding +1 votes are cast and there are more +1 than -1 votes.
>
> Release notes:
>
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-beta11-RC1/RELEASE_NOTES-5.0.x.txt
>
> Maven artefacts:
>
> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1106/org/apache/httpcomponents/core5/
>
> Git Tag: 5.0-beta11-RC1
>  https://github.com/apache/httpcomponents-core/tree/5.0-beta11-RC1
>
> Packages:
>
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-beta11-RC1
>  revision 37450
>
> Hashes:
>  
> b131ddfcfd6413ad492c7bc28b62380a15431f752ee33c274c3f86722ec7ba3d4f3564fc6ec645a0eb3103a12781135685d507b8e371a106881e479f1add1d5a
> httpcomponents-core-5.0-beta11-src.zip
>  
> 237a652f1ce2cb84cfef6ef49597a68db74a15948ac35feaf3ff1f61e095813bc3351599a3e40030763d17f365c075ca833e5162fefe95be3264c6f15ba6a12c
> httpcomponents-core-5.0-beta11-src.tar.gz
>  
> 7c7e8e7746462bdfb1d80ba4b2f5fd5ce457404bbbb076babc92bb17ecbe865aaede7930940f60ea2f8cbbac96b6c20cc97707f5a7ea9de32a028e860f461424
> httpcomponents-core-5.0-beta11-bin.zip
>  
> bf705fbee650270f4d53b897841a6978110a489ed2e7aab5d8ee132a06cfe5575c75102d7999c289ae36d384ff631339d3e1ee40abfa0fa95e074510e5b287e2
> httpcomponents-core-5.0-beta11-bin.tar.gz
>
> Keys:
>  http://www.apache.org/dist/httpcomponents/httpcore/KEYS
>
> --------------------------------------------------------------------------
> Vote: HttpCore 5.0-beta11 release
> [ ] +1 Release the packages as HttpCore 5.0-beta11.
> [ ] -1 I am against releasing the packages (must include a reason).
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to