michael-o commented on a change in pull request #197: Rename CookieSpecs enum
to StandardCookieSpec final class
URL:
https://github.com/apache/httpcomponents-client/pull/197#discussion_r363270967
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/cookie/StandardCookieSpec.java
##########
@@ -28,33 +28,31 @@
package org.apache.hc.client5.http.cookie;
/**
- * Supported cookie specifications.
+ * Cookie specifications by their names supported by the HttpClient.
*
* @since 4.3
*/
-public enum CookieSpecs {
+public final class StandardCookieSpec {
Review comment:
Valid question. We have throughout the codebase now singular name
classes/enums for some kind of identity. If that would be an enum, it would be
similar. I have chosen it to be a final class because we need string at the
end. I have picked up the idea of `StandardCharsets`, but not ultimately the
naming scheme. We now have a consistent naming scheme, imho, throughout the
entire code base. Enums for exhaustive identities, final classes for
non-exhaustive.
I can update the commit message to make that clear if you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
