garydgregory commented on a change in pull request #184: Path entity URL: https://github.com/apache/httpcomponents-core/pull/184#discussion_r366413543
########## File path: httpcore5/src/test/java/org/apache/hc/core5/http/io/entity/TestPathEntity.java ########## @@ -0,0 +1,105 @@ +/* + * ==================================================================== + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * ==================================================================== + * + * This software consists of voluntary contributions made by many + * individuals on behalf of the Apache Software Foundation. For more + * information on the Apache Software Foundation, please see + * <http://www.apache.org/>. + * + */ + +package org.apache.hc.core5.http.io.entity; + +import java.io.ByteArrayOutputStream; +import java.io.InputStream; +import java.io.OutputStream; +import java.nio.file.Files; +import java.nio.file.Path; + +import org.apache.hc.core5.http.ContentType; +import org.junit.Assert; +import org.junit.Test; + +/** + * Unit tests for {@link PathEntity}. + */ +public class TestPathEntity { + + @Test + public void testBasics() throws Exception { + final Path tmpPath = Files.createTempFile("testfile", ".txt"); + tmpPath.toFile().deleteOnExit(); + try (final PathEntity httpentity = new PathEntity(tmpPath, ContentType.TEXT_PLAIN)) { + Assert.assertEquals(Files.size(tmpPath), httpentity.getContentLength()); + try (final InputStream content = httpentity.getContent()) { + Assert.assertNotNull(content); + } + Assert.assertTrue(httpentity.isRepeatable()); + Assert.assertFalse(httpentity.isStreaming()); + if (!Files.deleteIfExists(tmpPath)) { + Assert.fail("Failed to delete: " + tmpPath); + } + } + } + + @Test + public void testNullConstructor() throws Exception { + try { + new PathEntity(null, ContentType.TEXT_PLAIN); + Assert.fail("NullPointerException should have been thrown"); + } catch (final NullPointerException ex) { + // expected + } + } + + @Test + public void testWriteTo() throws Exception { + final Path tmpPath = Files.createTempFile("testfile", ".txt"); + tmpPath.toFile().deleteOnExit(); + + try (final OutputStream outStream = Files.newOutputStream(tmpPath)) { + outStream.write(0); + outStream.write(1); + outStream.write(2); + outStream.write(3); + } + + try (final PathEntity httpentity = new PathEntity(tmpPath, ContentType.TEXT_PLAIN)) { + final ByteArrayOutputStream out = new ByteArrayOutputStream(); + httpentity.writeTo(out); + final byte[] bytes = out.toByteArray(); + Assert.assertNotNull(bytes); + Assert.assertEquals(Files.size(tmpPath), bytes.length); + for (int i = 0; i < 4; i++) { + Assert.assertEquals(i, bytes[i]); + } + if (!Files.deleteIfExists(tmpPath)) { Review comment: Added comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
