jepp-igus commented on issue #190: Allow trailing slash on creating HttpHost with a string URL: https://github.com/apache/httpcomponents-core/pull/190#issuecomment-577676148 > @michael-o This is precisely the reason why I was against having parsing logic in that class in the first place. But, oh, well. > @jepp-igus What is the benefit of a more lenient parsing logic here? What practical issue is it intended to fix? The 'create' method takes a string and tries to parse the HttpHost out of it. There is no definition on how the string has to look like, but it throws an exception because of a trailing slash. The developer using this function must subtract this char by himself and maybe write his own helper function parsing a string before calling HttpHost.create() with the same string and getting finally hist HttpHost. This is a small detail which doesn't break the whole logic, but if you like you can decline this PR. I can work further without this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
