ok2c commented on a change in pull request #205: Now that ClassicHttpRequests
is no longer an enum, we need to way to
URL:
https://github.com/apache/httpcomponents-client/pull/205#discussion_r371998505
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/BasicHttpRequests.java
##########
@@ -40,6 +42,38 @@
*/
public final class BasicHttpRequests {
+ // TODO Next version of HttpCore:
+ // Method.normalizedValueOf(method)
+ private static Method normalizedValueOf(final String method) {
+ return Method.valueOf(Objects.requireNonNull(method,
"method").toUpperCase(Locale.ROOT));
Review comment:
@garydgregory Please use `Args.notNull` for consistency with the rest of the
code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
