ok2c commented on a change in pull request #206: No input type name in method
name
URL:
https://github.com/apache/httpcomponents-client/pull/206#discussion_r372087256
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/SimpleHttpRequest.java
##########
@@ -85,11 +85,11 @@ public void setBody(final SimpleBody body) {
this.body = body;
}
- public void setBodyBytes(final byte[] bodyBytes, final ContentType
contentType) {
+ public void setBody(final byte[] bodyBytes, final ContentType contentType)
{
Review comment:
@garydgregory Please keep the original methods. Just deprecate them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
