garydgregory commented on issue #192: Deprecate org.apache.hc.core5.util.Args.notNull(T, String) in favor of URL: https://github.com/apache/httpcomponents-core/pull/192#issuecomment-581031306 It seems there is a severe disconnect here which I can only attribute to the the communication medium, if only we had a water cooler... From @michael-o: "Args still contains a lot of functionality cannot be replaced with plain Java" From @ok2c: "There are still a lot of functionality in Args that presently cannot be replaced by a JRE provided method." I do _not_ and the patch does _not_ remove the Args class I do am not advocating to replace all of it with JRE code; this patch is about the one API which is a clear duplicate of JRE functionality and reeks of NIH syndrome. I'm not even sure how to qualify this from @ok2c's: ``` Based on this flawed logic we should throw away the entire library because "duplicate code that is in the JRE". ``` Flame bait I guess.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
