h0nIg edited a comment on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585754127 @ok2c ok after looking at the code it is still not clear for me why you said it is inefficient. or it is not really clear for me what it really does https://github.com/apache/httpcomponents-core/blob/529b392b63229e1a4e658b1105332adaf3a89464/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java#L297 it sets a read timeout of 1 and it tries to read from an empty socket which was in the queue and should not have any further input content which can be streamed. if the check can not read data, the connection is expected to be stale?? what is the code really doing?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
