+1 My review is based on the git tag. - Apache RAT check OK - Apache CLIRR check OK
Building with 'mvn -V -P !use-toolchains clean package' using: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.7.0_80, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.7.0_80\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Java 8 passes with many Javadoc warnings which cause Java 11 to fail with these as Javadoc errors: We are missing a lot of Javadoc tags, using: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 11.0.6, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.6 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Wed, Mar 4, 2020 at 8:07 AM Oleg Kalnichevski <[email protected]> wrote: > Please vote on releasing these packages as HttpClient 4.5.12. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and there are more +1 than -1 votes. > > Release notes: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.5.12-RC1/RELEASE_NOTES-4.5.x.txt > > Maven artefacts: > > https://repository.apache.org/content/repositories/orgapachehttpcomponents-1113/org/apache/httpcomponents/ > > Git Tag: 4.5.12-RC1 > https://github.com/apache/httpcomponents-client/tree/4.5.12-RC1 > > Packages: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.5.12-RC1 > revision 38384 > > Hashes: > > 565cca7183dca7995e2e7af23d4aef68f4e3bb327f15f32182b8ab5b01b21b5f4b15831eb6b5cf505afcaa63cf9da3ac46933c1a642525021908c63add1ba579 > httpcomponents-client-4.5.12-src.zip > > d82d82e3dbdd58638b1b2a0cb0ca9ae5535a4481df3dc35d7640845b7b0f4481f50c27ac9f4a2883ef5db949fd494e59e21da867211de27469f6863da69e7cc4 > httpcomponents-client-4.5.12-bin.tar.gz > > 0e1e4117b1fc479669a896503d3431f2179cf5128feb6c0a12e01d07633712890984954719a88bcbb4b84484e88ad53c3993ef5955474b3984cceab88f790ef3 > httpcomponents-client-4.5.12-src.tar.gz > > 923c4d89d3d86b3e5fb36942202943cb7ad5a10ea9882c8a463332e8c612c8503492e8d3cd4b3ee64e6475d15c2211c812783a9226c7ef9ae25f0036912df21b > httpcomponents-client-4.5.12-bin.zip > > Keys: > http://www.apache.org/dist/httpcomponents/httpclient/KEYS > > -------------------------------------------------------------------------- > Vote: HttpClient 4.5.12 release > [ ] +1 Release the packages as HttpClient 4.5.12. > [ ] -1 I am against releasing the packages (must include a reason). > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
