On Mon, 2020-04-06 at 23:34 +0200, Ralph Geerkens wrote: > Hello, > > we are currently using http-client 4.5 and the fluent API and want to > switch to http-client5. For some requests it is important to us to be > able to set a timeout in case the server is not responding in time > after the request was made by the client. > > In 4.5 we used the method “public Request socketTimeout(int > timeout)”. The timeout was stored in the RequestConfig and is > eventually added to the HttpClientConnection which is used by > HttpRequestExecutor. > In 5.0 I found responseTimeout in the RequestConfig. Eventually the > timeout will be added to a HttpClientConnection used by a > ConnectionEndpoint which wraps a HttpRequestExecutor. > Is the responseTimeout the right configuration to achieve an early > termination of a request? > In case it is the right configuration can it be added to the Request > in the fluent API or are there any reasons not to add it? > > If the method sounds useful I can create a Jira issue and make the > change. I haven't committed anything to this project yet. What would > be the preferred way? > > Best regards > Ralph
Hi Ralph Please go ahead and raise a PR at GitHub. This is the easiest and fastest way to get one's changes incorporated into the main code line. cheers Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
