ufolr commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615417887 > > CharArrayBuffer's sub-sequence should return the result as same class of CharArrayBuffer. But' the old implementation use CharBuffer.wrap to make a result which instance of HeapCharBuffer. > > @ufolr Where is this requirement stated anywhere? I could not find any evidence of such requirement in `CharSequence` javadocs. @ok2c There is no specification. Just my suggestion. I think its return should be intuitive. Such as sub noodle is a noodle lol. There maybe some method which accept a **CharArrayBuffer** as parameter, but can't take the sub-sequence result of **CharArrayBuffer**. This will cause me confusion. Anyway, just my suggestion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
