[
https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086565#comment-17086565
]
Anurag Agarwal commented on HTTPASYNC-160:
------------------------------------------
This should work fine, few review comments:
1. Remove the commented line.
2. The try-catch section can be abstracted to the base class to avoid code
repetition.
> InternalHttpAsyncClient doesn't close gracefully
> ------------------------------------------------
>
> Key: HTTPASYNC-160
> URL: https://issues.apache.org/jira/browse/HTTPASYNC-160
> Project: HttpComponents HttpAsyncClient
> Issue Type: Bug
> Affects Versions: 4.1.4
> Reporter: Anurag Agarwal
> Priority: Minor
>
> InternalHttpAsyncClient:123 -> uses ensureRunning()
> This checks if the status of the client is active / stopped.
> Let us say a thread initiated a quested and before reaching this line, close
> is called as well on the client.
> Now ensureRunning call will fail but with a RuntimeException, leading to I/O
> Reactor failure and it won't be a graceful shutdown of the client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
