rafiek commented on a change in pull request #224:
URL:
https://github.com/apache/httpcomponents-client/pull/224#discussion_r426282637
##########
File path:
httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java
##########
@@ -954,7 +996,18 @@ public CloseableHttpClient build() {
requestExecCopy = new HttpRequestExecutor();
}
HttpClientConnectionManager connManagerCopy = this.connManager;
- if (connManagerCopy == null) {
+
+ final String socksProxyHost = System.getProperty("socksProxyHost");
+ final String socksProxyPort = System.getProperty("socksProxyPort");
Review comment:
And same here:
```suggestion
final String socksProxyPort = System.getProperty("socksProxyPort",
"1080");
```
If this is acceptable, then there is also no need to check if socksProxyPort
has been set on line 1003.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
