[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafiek Mohamedjoesoef updated HTTPCLIENT-2082:
----------------------------------------------
    Description: 
Adding the connection socket lookup as a parameter for the builder makes it 
more flexible to use this builder. When creating a default connection manager, 
the registry takes default values for http and https. In future use cases when 
a registry is supplied it could take into consideration other field values when 
adding the registry. Such as useSystemProperties. 

 
{code:java}
PoolingHttpClientConnectionManager mgr = 
PoolingHttpClientConnectionManagerBuilder.create()
        .setConnectionSocketFactoryRegistry(socketFactoryRegistry)
        .setSchemePortResolver(schemePortResolver)
        .setDnsResolver(dnsResolver)
        .setManagedConnPool(pool)
        .build();
{code}

  was:Adding the connection socket lookup as a parameter for the builder makes 
it more flexible to use this builder. When creating a default connection 
manager, the registry takes default values for http and https. In future use 
cases when a registry is supplied it could take into consideration other field 
values when adding the registry. Such as useSystemProperties. 


> PoolingHttpClientConnectionManagerBuilder should also take the connection 
> socket lookup as a construction parameter
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2082
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2082
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Rafiek Mohamedjoesoef
>            Priority: Minor
>
> Adding the connection socket lookup as a parameter for the builder makes it 
> more flexible to use this builder. When creating a default connection 
> manager, the registry takes default values for http and https. In future use 
> cases when a registry is supplied it could take into consideration other 
> field values when adding the registry. Such as useSystemProperties. 
>  
> {code:java}
> PoolingHttpClientConnectionManager mgr = 
> PoolingHttpClientConnectionManagerBuilder.create()
>         .setConnectionSocketFactoryRegistry(socketFactoryRegistry)
>         .setSchemePortResolver(schemePortResolver)
>         .setDnsResolver(dnsResolver)
>         .setManagedConnPool(pool)
>         .build();
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to