On Thu, Jun 4, 2020 at 10:16 AM Oleg Kalnichevski <[email protected]> wrote:
> On Thu, 2020-06-04 at 10:09 -0400, Gary Gregory wrote: > > Minor point " new method Request.responseTimeout(Timeout) in Fluent > > HC." > > should mean that the release is 5.1 since we've added a public API > > IMO. > > > > The method was omitted by mistake. Besides, what is really important is > that we can still change the method signature if we did not get it > right the first time around. The point of having ALPHA and BETA > releases is to get feedback before the APIs are frozen. How likely that > we have gotten that setter wrong? Probably not very likely. > I am mentioning this for the simple semver POV, you add an API, it's a minor version bump, regardless of the past or current intent/omission. Following semver this way is 'simple' in that it removes the need for a subjective judgment call. Either way will be OK I am sure. Gary > Oleg > > > I fixed typos in > > > > https://github.com/apache/httpcomponents-client/blob/release-preparation/RELEASE_NOTES.txt > > > > Gary > > > > On Thu, Jun 4, 2020 at 8:44 AM Oleg Kalnichevski <[email protected]> > > wrote: > > > > > Folks > > > > > > Please review and amend release notes for HttpCore 5.0.1 and > > > HttpClient > > > 5.0.1 > > > > > > > > > > > https://github.com/apache/httpcomponents-core/blob/release-preparation/RELEASE_NOTES.txt > > > > > > > > https://github.com/apache/httpcomponents-client/blob/release-preparation/RELEASE_NOTES.txt > > > > > > Oleg > > > > > > On Wed, 2020-06-03 at 12:44 -0700, Ryan Schmitt wrote: > > > > Sure, let's do it. > > > > > > > > On Wed, Jun 3, 2020 at 7:12 AM Oleg Kalnichevski < > > > > [email protected]> > > > > wrote: > > > > > > > > > Folks > > > > > > > > > > Should we release HttpCore / HttpClient 5.0.1 soon? There have > > > > > been > > > > > some bug fixes but nothing major if my memory servers me well. > > > > > > > > > > Oleg > > > > > > > > > > > > > > > ------------------------------------------------------------- > > > > > ---- > > > > > ---- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > ----------------------------------------------------------------- > > > ---- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
