On Sat, Jun 6, 2020 at 3:36 PM Oleg Kalnichevski <[email protected]> wrote:
> On Sat, 2020-06-06 at 19:42 +0200, Michael Osipov wrote: > > > > ... > > > The reason is: > > > Java™ SE Development Kit 8, Update 251 (JDK 8u251) > > > > > > April 14, 2020 > > > New Features > > > security-libs/javax.net.ssl > > > ➜ TLS Application-Layer Protocol Negotiation Extension > > > > > > JEP 244 has enhanced the Java Secure Socket Extension (JSSE) to > > > providesupport for the TLS Application-Layer Protocol Negotiation > > > (ALPN) Extension (RFC 7301). New methods have been added to the > > > javax.net.ssl classes SSLEngine, SSLSocket, and SSLParameters to > > > allow clients and servers to negotiate an application layer value > > > as part of the TLS handshake. > > > > > > This API change was required by JSR 337 MR 3. > > > > What now? Do we now need to check for the patch version? > > > > Folks > > All right. Oracle has just made our lives more complicated. > > But is this a good reason to derail a release? > Hm, probably not but my "solution: is then to simply trusting Oleg that it is not an issue at runtime. >From my POV though, the issue becomes that: - it makes very hard for another developer to pick the release sources and create a patch and validate it on their machine because they cannot get a clean build, depending on their JDK flavor. - it makes it harder for tools like Linux distros that build everything from sources if our build might fail depending on their JDK flavor. - there is no mention of this in the release notes, so it appears as a surprise (surprises are bad), and it is hard to know what the issue is, unless Oleg is around to shine a light on the matter. My preference would be at the very least to have another RC with release notes that tells users what to expect and at best a fix in the test that relaxes expected values. Gary > > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
