rafiek commented on a change in pull request #228:
URL:
https://github.com/apache/httpcomponents-client/pull/228#discussion_r445476391
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
##########
@@ -70,10 +74,13 @@
*/
public class PoolingHttpClientConnectionManagerBuilder {
+ private Lookup<ConnectionSocketFactory> connectionSocketFactoryRegistry;
Review comment:
When omitting the use of this variable for `'build()`, you can still use
`sslSocketFactory` as part of `build()`.
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
##########
@@ -70,10 +74,13 @@
*/
public class PoolingHttpClientConnectionManagerBuilder {
+ private Lookup<ConnectionSocketFactory> connectionSocketFactoryRegistry;
Review comment:
@ok2c When omitting the use of this variable for `'build()`, you can
still use `sslSocketFactory` as part of `build()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
