michael-o commented on a change in pull request #235:
URL:
https://github.com/apache/httpcomponents-client/pull/235#discussion_r449903072
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -252,7 +252,7 @@ public void completed(final PoolEntry<HttpRoute,
ManagedAsyncClientConnection> p
@Override
public void execute(final Boolean result) {
- if (result == Boolean.FALSE) {
+ if (!result) {
Review comment:
Can this actually lead to an NPE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
