nielsbasjes commented on pull request #234: URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-654048215
@michael-o At this moment I have limited experience in using modules. So for making this patch I did some digging and what I found is that these module names must be just as unique as the name of packages and artifacts. Quote from: https://openjdk.java.net/projects/jigsaw/spec/sotms/#module-declarations > Module names, like package names, must not conflict. The recommended way to name a module is to use the reverse-domain-name pattern that has long been recommended for naming packages. The name of a module will, therefore, often be a prefix of the names of its exported packages, but this relationship is not mandatory. So that is why in my pull requests I used exactly that: ```groupId.artifactId``` which is essentially the same as what was done for the 4.x versions. See also https://stackoverflow.com/questions/43192741/how-should-i-name-my-java-9-module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
