[
https://issues.apache.org/jira/browse/HTTPCLIENT-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156024#comment-17156024
]
ASF subversion and git services commented on HTTPCLIENT-2095:
-------------------------------------------------------------
Commit 84bd29095484ac1f31599c07405b29bf5fa9814d in httpcomponents-client's
branch refs/heads/5.1.x from Carter Kozak
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=84bd290 ]
HTTPCLIENT-2095: Use slf4j interpolation instead of string concatenation where
possible (#232)
> Consider replacing concatenation into slf4j loggers with interpolation
> ----------------------------------------------------------------------
>
> Key: HTTPCLIENT-2095
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2095
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpCache
> Affects Versions: 5.0.1
> Reporter: Carter Kozak
> Priority: Minor
> Fix For: 5.0.2
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In most cases these statements are protected by a conditional to check if the
> logger is enabled so there shouldn't be a real performance impact, replacing
> concatenation would result in code aligned with modern logging
> recommendations, and improve perf in a few cases that aren't guarded (though
> at a glance I don't see any in hot paths).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
