ok2c commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-667196432
@carterkozak I understand the intent and benefits of this approach but what I do not quite like about it that it effectively breaks the principle of separation of concerns and turns the strategy into `OutputStream` factory. Here is a very simple implementation of what I am proposing instead: 93c054967d54f824393b6257d354a0155cd087fe. I extracted the strategy logic into a separate class, which can be turned into an interface with multiple implementations including a no-op one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
