michael-o commented on a change in pull request #211:
URL:
https://github.com/apache/httpcomponents-core/pull/211#discussion_r465574464
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnectionFactory.java
##########
@@ -140,12 +140,12 @@ public Builder charCodingConfig(final CharCodingConfig
charCodingConfig) {
return this;
}
- public Builder incomingContentStrategy(final ContentLengthStrategy
incomingContentStrategy) {
+ public Builder incomingContentLengthStrategy(final
ContentLengthStrategy incomingContentStrategy) {
Review comment:
You forgot to rename the instance field names and argument name. They
are still misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
