michael-o commented on a change in pull request #212:
URL:
https://github.com/apache/httpcomponents-core/pull/212#discussion_r465706546
##########
File path:
httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java
##########
@@ -233,7 +233,7 @@ public void testNegotiateProtocol() throws Exception {
final HttpResponse response1 = message1.getHead();
Assert.assertThat(response1.getCode(),
CoreMatchers.equalTo(HttpStatus.SC_OK));
- if (javaVersion >= 9) {
+ if (javaVersion >= 8) {
Review comment:
Ancient on Trusty: java version "1.8.0_151". This one is almost 4 years
old. I consider this to be a realistic test env anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
