carterkozak commented on pull request #220: URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682097219
I noticed [this one]( https://github.com/apache/httpcomponents-client/pull/253) while reading through some code and decided to check for others around our calls to `Buffer.array()`. It's relatively rare for array-backed buffers to have an offset since it requires a call to `Buffer.slice()`, but I it's safest to keep this in mind to prevent edge case failures. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
