+1 My review is based on the src zip. SHA512 OK Apache RAT check OK Apache CLIRR check OK
On Java 11 and above, the tests emit: [ERROR] WARNING: An illegal reflective access operation has occurred [ERROR] WARNING: Illegal reflective access by org.apache.hc.core5.util.ReflectionUtils$1 (file:/C:/d3vsrc/m2_repo/org/apache/httpcomponents/core5/httpcore5/5.0.2/httpcore5-5.0.2.jar) to method sun.security.ssl.SSLEngineImpl.getApplicationProtocol() [ERROR] WARNING: Please consider reporting this to the maintainers of org.apache.hc.core5.util.ReflectionUtils$1 [ERROR] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations [ERROR] WARNING: All illegal access operations will be denied in a future release 'mvn clean package' OK with toolchains on: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_265,* vendor: *AdoptOpenJDK*, runtime: C:\Program Files\AdoptOpenJDK\jdk-8.0.265.01-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "*windows*" with toolchains pointing to: JDK[C:\Program Files\Java\jdk1.7.0_80] 'mvn clean package -P !use-toolchains' OK on: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec Java version: *1.8.0_265*, vendor: *AdoptOpenJDK*, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "*mac*" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec Java version: *11.0.8*, vendor: *AdoptOpenJDK*, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "*mac*" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_265,* vendor: *AdoptOpenJDK*, runtime: C:\Program Files\AdoptOpenJDK\jdk-8.0.265.01-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "*windows*" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *11.0.8*, vendor: *AdoptOpenJDK*, runtime: C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "*windows*" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *15*, vendor: *Oracle *Corporation, runtime: C:\Program Files\Java\openjdk\jdk-15 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "*windows*" Gary On Wed, Sep 23, 2020 at 2:36 PM Oleg Kalnichevski <[email protected]> wrote: > Please vote on releasing these packages as HttpClient 5.0.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and there are more +1 than -1 votes. > > Release notes: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-5.0.2-RC1/RELEASE_NOTES-5.0.x.txt > > Maven artefacts: > > https://repository.apache.org/content/repositories/orgapachehttpcomponents-1120/org/apache/httpcomponents/client5/ > > Git Tag: 5.0.2-RC1 > https://github.com/apache/httpcomponents-client/tree/5.0.2-RC1 > > Packages: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-5.0.2-RC1 > revision 41553 > > Hashes: > > cbe55690f6c1c25226dbb8ef12ff355284821906aec91feada76cb09f06ca8feafc0d5655fe432afd1feff648fe683f26e6711112673282bafb4a1b78524baf6 > httpcomponents-client-5.0.2-src.tar.gz > > 403b8f5b3b8f7f76ba745138906af78e81b4f85bac3f88645ea536138b4c049ca358ec511038d6d9863cfbac3239577f443cb7d157ed85b1723babb0e5f11664 > httpcomponents-client-5.0.2-bin.tar.gz > > b135538e9641b46e5c944d3b13e5e338b407d0f0c42f8260551a6c20c2eabc8ada3ad999597699338f3e7aa448feeec1e975bc852d26f3c17756327ab6ad6a1a > httpcomponents-client-5.0.2-bin.zip > > 6c67587883717eb6a1cc55541f3d7c0160434ce3cc19f31c41a49bd1b894198a315f451275965c54da8d0d5c18e5e7eccad07cd33c471c194d5fd0e4af4e2ccf > httpcomponents-client-5.0.2-src.zip > > Keys: > http://www.apache.org/dist/httpcomponents/httpclient/KEYS > > -------------------------------------------------------------------------- > Vote: HttpClient 5.0.2 release > [ ] +1 Release the packages as HttpClient 5.0.2. > [ ] -1 I am against releasing the packages (must include a reason). > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
