[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218454#comment-17218454
 ] 

ASF subversion and git services commented on HTTPCLIENT-2123:
-------------------------------------------------------------

Commit e73b33c18bff8daf701b115b56b5d6557131c58d in httpcomponents-client's 
branch refs/heads/master from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=e73b33c ]

HTTPCLIENT-2123: H2AsyncClientBuilder incorrectly adds last request 
interceptors to the head of the interceptor list


> H2AsyncClientBuilder doesn't add RequestInterceptorEntry.Postion.LAST with 
> correct method
> -----------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2123
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2123
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async)
>    Affects Versions: 5.0.3
>            Reporter: koji lin
>            Priority: Minor
>
> Code at Line 656 adding LAST using addFirst. It should be addLast.
> {code:java}
> if (requestInterceptors != null) {
>     for (final RequestInterceptorEntry entry: requestInterceptors) {
>         if (entry.postion == RequestInterceptorEntry.Postion.LAST) {
>             b.addFirst(entry.interceptor);
>         }
>     }
> }
> if (responseInterceptors != null) {
>     for (final ResponseInterceptorEntry entry: responseInterceptors) {
>         if (entry.postion == ResponseInterceptorEntry.Postion.LAST) {
>             b.addLast(entry.interceptor);
>         }
>     }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to