[
https://issues.apache.org/jira/browse/HTTPCLIENT-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226769#comment-17226769
]
koji lin edited comment on HTTPCLIENT-2126 at 11/5/20, 3:27 PM:
----------------------------------------------------------------
I think `dataConsumer.streamEnd(null);` should be included too.
Because in some consumer(maybe
org.apache.hc.core5.http.nio.support.BasicResponseConsumer?), if we don't call
consume first, dataConsumerRef in streamEnd will be null and NPE in `streamEnd`
was (Author: kojilin):
I think `dataConsumer.streamEnd(null);` should be included too.
Because in some consumer(maybe
org.apache.hc.core5.http.nio.support.BasicResponseConsumer?), if we don't call
consume first, dataConsumerRef in streamEnd will be null.
> AsyncCachingExec throws NPE when response body is null
> ------------------------------------------------------
>
> Key: HTTPCLIENT-2126
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2126
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (async)
> Affects Versions: 5.0.3
> Reporter: koji lin
> Priority: Minor
> Fix For: 5.0.4, 5.1-beta1
>
>
> [https://github.com/apache/httpcomponents-client/blob/master/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java#L160]
>
> This makes client's returned future/callback
> susccess(AsyncExecCallback#handleResponse triggers this?) but
> AsyncResponseConsumer/AsyncExecCallback failed.
>
> Curious if it should avoid exception here.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
