[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227241#comment-17227241
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-2126:
-----------------------------------------------

[~kojilin] I made `AbstractAsyncResponseConsumer` handle gracefully an 
inconsistent state caused by the caller signalling a response with no entity 
but subsequently calling methods to consume data.

[https://github.com/apache/httpcomponents-core/commit/5d413a44c3a067bd7af6088bfe7d9e3f362675a8]

However the real cause of this defect was actually 
`InternalAbstractHttpAsyncClient` incorrect handling of response messages with 
no enclosed entity.  

[https://github.com/apache/httpcomponents-client/commit/f6333a5001450ec68b47bdb019e78b97a74f25f2]

Oleg

> AsyncCachingExec throws NPE when response body is null
> ------------------------------------------------------
>
>                 Key: HTTPCLIENT-2126
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2126
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async)
>    Affects Versions: 5.0.3
>            Reporter: koji lin
>            Priority: Minor
>             Fix For: 5.0.4, 5.1-beta1
>
>
> [https://github.com/apache/httpcomponents-client/blob/master/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java#L160]
>  
> This makes client's returned future/callback 
> susccess(AsyncExecCallback#handleResponse triggers this?) but 
> AsyncResponseConsumer/AsyncExecCallback failed.
>  
> Curious if it should avoid exception here.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to