ok2c commented on a change in pull request #241:
URL:
https://github.com/apache/httpcomponents-core/pull/241#discussion_r550476432
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java
##########
@@ -58,12 +58,12 @@
/**
* The maximum (longest-lived) deadline.
*/
- public static Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
+ public static final Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
/**
* The minimum (shortest-lived) deadline.
*/
- public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
+ public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
Review comment:
@arturobernalg I am afraid this will could as an API / binary
compatibility breakage. Could you please run `mvn clirr:check` and see that it
passes with your changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
