carterkozak commented on a change in pull request #242:
URL:
https://github.com/apache/httpcomponents-core/pull/242#discussion_r551565514
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java
##########
@@ -58,12 +58,12 @@
/**
* The maximum (longest-lived) deadline.
*/
- public static Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
+ public static final Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
/**
* The minimum (shortest-lived) deadline.
*/
- public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
+ public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
Review comment:
@ok2c I think the analyzer is telling us that if we make the field final
any users who already attempt to replace the default zero value with a
different one will be broken, however it's my understanding that would result
in other bugs because we expect MIN_VALUE to be zero (and constant) internally.
The question is whether or not it's important to continue allowing library
consumers to set the field with custom values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
