tony-- commented on pull request #251: URL: https://github.com/apache/httpcomponents-core/pull/251#issuecomment-769289950
@michael-o it was only added in 4.4.13, as you can see in the diff here: https://github.com/apache/httpcomponents-core/compare/rel/v4.4.12...rel/v4.4.13 In the component it is actually used in, the scope is [correctly defined](https://github.com/apache/httpcomponents-core/compare/rel/v4.4.12...rel/v4.4.13#diff-552f7b836a536f89239e8a4c8e8b7e562fbfdbe20eafa9fc52936f5000a514c4R52). I also checked out 4.4.13 to submit my PR and searched all the files. Here are the results: Searching 680 files for "conscrypt" (regex, case sensitive) /home/tony/development/httpcomponents-core/httpcore-nio/pom.xml: 50: <groupId>org.conscrypt</groupId> 51: <artifactId>conscrypt-openjdk-uber</artifactId> /home/tony/development/httpcomponents-core/httpcore-nio/src/test/java/org/apache/http/nio/integration/TestJSSEProviderIntegration.java: 64: import org.conscrypt.Conscrypt; /home/tony/development/httpcomponents-core/pom.xml: 79: <conscrypt.version>2.2.1</conscrypt.version> 90: <groupId>org.conscrypt</groupId> 91: <artifactId>conscrypt-openjdk-uber</artifactId> 92: <version>${conscrypt.version}</version> 8 matches across 3 files ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
