ok2c commented on a change in pull request #267:
URL:
https://github.com/apache/httpcomponents-core/pull/267#discussion_r582687442
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a
href="https://tools.ietf.org/html/rfc2109#section-4.2.2";>Section 4.2.2 of RFC
2109</a>
Review comment:
@arturobernalg I am not sure about references to RFCs in the source
code. For instance, HttpClient conforms to rfc6265 and not rfc2109. I would not
want to scan the source code for RFC references every time protocol level gets
upgraded.
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a
href="https://tools.ietf.org/html/rfc2109#section-4.2.2";>Section 4.2.2 of RFC
2109</a>
+ */
+ public static final String SET_COOKIE = "Set-Cookie";
+ /**
+ * The HTTP {@code Set-Cookie2} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2965";>RFC 2965</a>
+ */
+ public static final String SET_COOKIE2 = "Set-Cookie2";
Review comment:
@arturobernalg `Set-Cookie2` is considered obsolete and should not be
used. I would not include it,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
